Replace gloo-timers with futures-timer
#154
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Migrated Sleeper implementation from `gloo-timers` to async runtime-agnostic `futures-timer` - Adjusted feature flags and updated dependencies to reflect this change, ensuring seamless functionality across different environments: - `gloo-timers-sleep` feature kept for backwards compatibility, it will imply the automatically `futures-timer-sleep` - if `wasm32` architecture is detected, it automatically enables the `gloo-timers` feature on `futures-timer` crate to ensure WASM compatibility. Closes Xuanwo#153
Xuanwo
requested changes
Oct 18, 2024
Xuanwo
reviewed
Oct 18, 2024
|
Thanks for the comments. I will improve it. |
|
@Xuanwo I pushed some changes. Let me know if a type alias for |
Thank you for your efforts; I prefer to leave them unchanged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Migrated Sleeper implementation from
gloo-timersto async runtime-agnosticfutures-timerAdjusted feature flags and updated dependencies to reflect this change, ensuring seamless functionality across different environments:
gloo-timers-sleepfeature kept for backwards compatibility, it will imply the automaticallyfutures-timer-sleepif
wasm32architecture is detected, it automatically enables thegloo-timers+wasm-bindgenfeatures onfutures-timercrate to ensure WASM compatibility.Closes #153